Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11818 )
Change subject: catalog_manager: fix a TSAN race ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11818/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11818/1//COMMIT_MSG@9 PS1, Line 9: n nit: an extra 'n' http://gerrit.cloudera.org:8080/#/c/11818/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/11818/1/src/kudu/master/catalog_manager.cc@735 PS1, Line 735: std::lock_guard<RWMutex> leader_lock_guard(leader_lock_); It seems the lock will be released once the outer scope ends at line 744 of the new revision, so background_tasks_ would not be protected anymore by this lock. Is this intentional? -- To view, visit http://gerrit.cloudera.org:8080/11818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I090a832b7fb25d8cb1e770c025048f73ac997eac Gerrit-Change-Number: 11818 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 29 Oct 2018 21:45:02 +0000 Gerrit-HasComments: Yes
