Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 )
Change subject: [location_awareness] Add location info in ksck report ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/11422/12/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/11422/12/src/kudu/tools/ksck-test.cc@1620 PS12, Line 1620: CheckJsonStringVsKsckResults > That just means an error from this function would not be caught as soon as Done http://gerrit.cloudera.org:8080/#/c/11422/14/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: http://gerrit.cloudera.org:8080/#/c/11422/14/src/kudu/tools/ksck_remote-test.cc@280 PS14, Line 280: string match_string = "Error fr > nit: is it really needed? opps, forgot to remove -- To view, visit http://gerrit.cloudera.org:8080/11422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ideff2dd4975c99a1135002624debbbb2620fb95c Gerrit-Change-Number: 11422 Gerrit-PatchSet: 12 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 30 Oct 2018 00:37:15 +0000 Gerrit-HasComments: Yes
