Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11834 )
Change subject: thirdparty: work around an upstream LLVM build race ...................................................................... Patch Set 2: (2 comments) Looks good to me. Bash nit-picking below, but I think it's fine. Have you observed this succeed with retries? http://gerrit.cloudera.org:8080/#/c/11834/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/11834/2/thirdparty/build-definitions.sh@347 PS2, Line 347: ${NINJA:-make} -j$PARALLEL $EXTRA_MAKEFLAGS install Do we need a "clean" before this? i.e., does this actually work if it dies where we think it dies? http://gerrit.cloudera.org:8080/#/c/11834/2/thirdparty/build-definitions.sh@347 PS2, Line 347: ${NINJA:-make} -j$PARALLEL $EXTRA_MAKEFLAGS install : exit_status=$? : if [[ $exit_status -eq 0 ]]; then : break This is just: ${NINJA:-make} -j$PARALLEL $EXTRA_MAKEFLAGS intall && break .... -- To view, visit http://gerrit.cloudera.org:8080/11834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3bf2a171b85d34326e187a4d14dbffe7326100d Gerrit-Change-Number: 11834 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 31 Oct 2018 15:46:09 +0000 Gerrit-HasComments: Yes
