Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11841 )
Change subject: [cmake] place all DATA_FILE under bin/testdata ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11841/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11841/1//COMMIT_MSG@7 PS1, Line 7: DATA_FILE Nit: DATA_FILES Below too. http://gerrit.cloudera.org:8080/#/c/11841/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/11841/1/CMakeLists.txt@834 PS1, Line 834: set(DATA_FILE_LIST "") I think set(DATA_FILES_LIST) suffices. -- To view, visit http://gerrit.cloudera.org:8080/11841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75064c6bcf9a569648b922b55f539730769cdf4c Gerrit-Change-Number: 11841 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 31 Oct 2018 22:40:35 +0000 Gerrit-HasComments: Yes
