Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11267 )
Change subject: common: add equality methods to ColumnBlock and SelectionVector ...................................................................... common: add equality methods to ColumnBlock and SelectionVector These are useful in tests. I also snuck in a change to ScopedColumnBlock that should simplify tests: all rows begin nulled out. This means two freshly created ScopedColumnBlocks are equal as per ColumnBlock::Equals; previously the garbage data in data_ and null_bitmap_ virtually guaranteed inequality. Change-Id: I9712bd7748bb01af7b6f68897a453a0aa149cdcf Reviewed-on: http://gerrit.cloudera.org:8080/11267 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <a...@cloudera.com> --- M src/kudu/common/CMakeLists.txt A src/kudu/common/columnblock-test.cc M src/kudu/common/columnblock.h A src/kudu/common/rowblock-test.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h 6 files changed, 160 insertions(+), 2 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9712bd7748bb01af7b6f68897a453a0aa149cdcf Gerrit-Change-Number: 11267 Gerrit-PatchSet: 12 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
