Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11832 )

Change subject: [docs] WARN_AS_ERROR requires doxygen >= 1.8.11
......................................................................


Patch Set 4:

> So this means you can't run make_site.sh on el7 easily, right? What
 > distros do our release managers use when doing a release? Will this
 > be inconvenient for them?

That's a good point.  After some consideration I realized that I don't want to 
add restriction on the platform our RM use just because of this.  It seems a 
better approach would leaving the version requirement as is, so it will 
automatically kick in when running with a newer version of the doxygen tool.

The presence of WARN_AS_ERROR works with older versions of doxygen, but the 
tool emits additional warnings about unknown configuration parameter.  Maybe, 
I'll just make the presence of that parameter dependent on the doxygen's 
version.


--
To view, visit http://gerrit.cloudera.org:8080/11832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f2cfc0a9765ee0641f1cf0138ce92e54d18ce96
Gerrit-Change-Number: 11832
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Thu, 01 Nov 2018 04:49:34 +0000
Gerrit-HasComments: No

Reply via email to