Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 )
Change subject: [sentry] add AuthzProvider ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/11659/6/src/kudu/master/sentry_authz_provider-test.cc File src/kudu/master/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/11659/6/src/kudu/master/sentry_authz_provider-test.cc@52 PS6, Line 52: namespace kudu { > warning: using decl 'vector' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/11659/6/src/kudu/master/sentry_authz_provider-test.cc@56 PS6, Line 56: namespace master { > warning: using decl 'SentryClient' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/11659/6/src/kudu/master/sentry_authz_provider-test.cc@122 PS6, Line 122: privilege.__set_serverName(FLAGS_server_name); > warning: parameter 'grant_option' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/11659/6/src/kudu/master/sentry_authz_provider.h File src/kudu/master/sentry_authz_provider.h: http://gerrit.cloudera.org:8080/#/c/11659/6/src/kudu/master/sentry_authz_provider.h@59 PS6, Line 59: // TODO(hao): add early failure recognition when SENTRY-2440 is done. > warning: missing username/bug in TODO [google-readability-todo] Done -- To view, visit http://gerrit.cloudera.org:8080/11659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I254828d640cd905e33dbaf0fe100d660bc9e6772 Gerrit-Change-Number: 11659 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 01 Nov 2018 05:11:16 +0000 Gerrit-HasComments: Yes
