Hello Mike Percy, David Ribeiro Alves, Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11858
to review the following change.
Change subject: delta_store: support iteration with snap_to_exclude
......................................................................
delta_store: support iteration with snap_to_exclude
This patch changes the delta stores (DMS and delta files) to respect
snap_to_exclude during iteration. The key changes are:
- The introduction of the "selection" criteria, a new delta relevancy
formula for determining whether a delta applies to a scan with both
snap_to_exclude and snap_to_include. The existing "application" criteria
was formalized and moved into delta_relevancy.h. There was also a
non-trivial change to DeltaFileReader::IsRelevantForSnapshot() to use both
criterias when culling entire delta files.
- A new SelectUpdates() method for using the selection criteria on a batch
of prepared deltas. SelectUpdates() requires new in-memory state, the
creation of which is gated behind a new PREPARE_FOR_SELECT flag so as not
to affect regular scans.
- Updates to the delta fuzz testing logic to test iterators with two
timestamps, and to provide SelectUpdates() coverage.
A future patch will modify DeltaApplier to use SelectUpdates for diff scans.
Change-Id: I7811e185fef270f40fdbbb38f491eee8b4aa043c
---
M src/kudu/tablet/delta_iterator_merger.cc
M src/kudu/tablet/delta_iterator_merger.h
A src/kudu/tablet/delta_relevancy.h
M src/kudu/tablet/delta_store.cc
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/tablet-test-util.cc
M src/kudu/tablet/tablet-test-util.h
11 files changed, 468 insertions(+), 92 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/11858/1
--
To view, visit http://gerrit.cloudera.org:8080/11858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7811e185fef270f40fdbbb38f491eee8b4aa043c
Gerrit-Change-Number: 11858
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
