Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11865 )
Change subject: move HashAlgorithm from common.proto to hash.proto ...................................................................... move HashAlgorithm from common.proto to hash.proto Commit 8af288a26 added a dependency from the bloom filter code onto common, creating a circular dependency. Normally that's caught by cmake, but the commit didn't actually establish the util->common dependency in cmake, which meant that the underlying parallelism of the build (and whether it was a clean or incremental build) dictated whether common.pb.h was present on-disk at the time that bloom_filter.h was included. This patch resolves the circular dependency by moving the HashAlgorithm enum out of common.proto and into a new hash.proto within util. An alternative would be to move the bloom filter code itself into common, but as it isn't specific to Kudu, I think util is a better home for it. Change-Id: I2b0a4077335de75dfed6aa1c6d78d9e197250976 Reviewed-on: http://gerrit.cloudera.org:8080/11865 Reviewed-by: Grant Henke <[email protected]> Reviewed-by: Andrew Wong <[email protected]> Tested-by: Adar Dembo <[email protected]> --- M src/kudu/common/CMakeLists.txt M src/kudu/common/common.proto M src/kudu/util/CMakeLists.txt M src/kudu/util/bloom_filter.h A src/kudu/util/hash.proto 5 files changed, 55 insertions(+), 19 deletions(-) Approvals: Grant Henke: Looks good to me, approved Andrew Wong: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/11865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2b0a4077335de75dfed6aa1c6d78d9e197250976 Gerrit-Change-Number: 11865 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
