Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/6348 )
Change subject: KUDU-1918 Prevent hijacking of scanner IDs ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/6348/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/6348/6//COMMIT_MSG@15 PS6, Line 15: scans Including fault tolerant ones, right? http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/client/client-test.cc@5753 PS6, Line 5753: Open Can you test with a fault tolerant scan as well? http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/tserver/scanners-test.cc File src/kudu/tserver/scanners-test.cc: http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/tserver/scanners-test.cc@45 PS6, Line 45: using rpc::RemoteUser; nit: move it to L44. http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/tserver/scanners.h File src/kudu/tserver/scanners.h: http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/tserver/scanners.h@69 PS6, Line 69: The client nit: mention it has to be the same client. http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/tserver/scanners.h@82 PS6, Line 82: // Create a new scanner with a unique ID, inserting it into the map. nit: update it to reflect how 'remote_user' is used. http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/tserver/tablet_server-test.cc@3406 PS6, Line 3406: TEST_F(TabletServerTest, TestScannerCheckMatchingUser) { nit: add a doc for this? http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/6348/6/src/kudu/tserver/tablet_service.cc@1302 PS6, Line 1302: PREDICT_FALSE I think it is probably rare to get an NOT_AUTHORIZED error, but do you think it is rare to get SCANNER_EXPIRED error as well? -- To view, visit http://gerrit.cloudera.org:8080/6348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic91fa0ca471bd674e35aa2f8de3806b88ad4b3b4 Gerrit-Change-Number: 6348 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 02 Nov 2018 23:15:12 +0000 Gerrit-HasComments: Yes