Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11862 )
Change subject: [rebalancer] location-aware rebalancer (part 9/n) ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/11862/2/src/kudu/tools/placement_policy_util-test.cc File src/kudu/tools/placement_policy_util-test.cc: http://gerrit.cloudera.org:8080/#/c/11862/2/src/kudu/tools/placement_policy_util-test.cc@142 PS2, Line 142: lhs, : > There's a default comparison operator in C++? I didn't think there was. How Woops, it seems I confused that with default copy constructor which works on field-by-field basis. It seems I was too grumpy yesterday night :) http://gerrit.cloudera.org:8080/#/c/11862/2/src/kudu/tools/placement_policy_util-test.cc@143 PS2, Line 143: hs) { > nonsense Done http://gerrit.cloudera.org:8080/#/c/11862/2/src/kudu/tools/rebalancer.cc File src/kudu/tools/rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/11862/2/src/kudu/tools/rebalancer.cc@129 PS2, Line 129: information > information Done http://gerrit.cloudera.org:8080/#/c/11862/2/src/kudu/tools/rebalancer.cc@137 PS2, Line 137: lance. > violations Done http://gerrit.cloudera.org:8080/#/c/11862/2/src/kudu/tools/rebalancer.cc@138 PS2, Line 138: RETURN_NOT_OK(PrintCrossLocationBalanceStats(ci, out)); > It looks like the output could be kind of long. Can we move placement polic Done http://gerrit.cloudera.org:8080/#/c/11862/2/src/kudu/tools/rebalancer.cc@145 PS2, Line 145: ons.res > sorted Done -- To view, visit http://gerrit.cloudera.org:8080/11862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8407e9f8cf6b41a6aeb075372d852125d9739e08 Gerrit-Change-Number: 11862 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 02 Nov 2018 23:30:20 +0000 Gerrit-HasComments: Yes
