Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11870 )
Change subject: [tools] reference comparison mode for rebalancing algo tests ...................................................................... [tools] reference comparison mode for rebalancing algo tests Introduced comparison mode for rebalancing algorithms' tests. For current rebalancing algorithms, it's natural to re-order contiguous moves of the same weight. That's because of: * Iterating over elements of a hash container keyed by the weight of a move. * Randomly choosing among multiple options of the same weight. This patch adds MovesOrderingComparison::IGNORE option into one test configuration of the RebalanceAlgoUnitTest.LocationBalancingSimpleST scenario. That fixes the breakage of the test on Ubuntu 18. Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91 Reviewed-on: http://gerrit.cloudera.org:8080/11870 Tested-by: Kudu Jenkins Reviewed-by: Will Berkeley <wdberke...@gmail.com> --- M src/kudu/tools/rebalance_algo-test.cc 1 file changed, 60 insertions(+), 5 deletions(-) Approvals: Kudu Jenkins: Verified Will Berkeley: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91 Gerrit-Change-Number: 11870 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>