Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11898 )
Change subject: De-flake sentry_client-test and sentry_authz_provider-test ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11898/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11898/1//COMMIT_MSG@14 PS1, Line 14: This commit sets this configuration with port 0 to ensure the mini Sentry : service can always find a free port to bound to. When running : sentry_client-test and sentry_authz_provider-test in parallel on the : same machine: before the change, one of the tests failed with : BindException; after the change, both tests passed without any errors. Would it make sense to have a test that instantiates two MiniSentry instances? Would such a test have caught this? -- To view, visit http://gerrit.cloudera.org:8080/11898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0 Gerrit-Change-Number: 11898 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Nov 2018 17:19:05 +0000 Gerrit-HasComments: Yes
