Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11857 )
Change subject: (02/05) delta_store: convert DeltaIterator::PrepareBatch flags into bitfield ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11857/2/src/kudu/tablet/delta_store.h File src/kudu/tablet/delta_store.h: http://gerrit.cloudera.org:8080/#/c/11857/2/src/kudu/tablet/delta_store.h@205 PS2, Line 205: // 'flags' is a bitfield describing what operation(s) the batch will be used Nit: Is there a more descriptive name that could be used? prepairForFlags? I assume the intent of this bitfield is only to be used to identify the target use of the batch. -- To view, visit http://gerrit.cloudera.org:8080/11857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id500ec3cc9459a78ae1098be3f3cd0cacb7a7a1a Gerrit-Change-Number: 11857 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 07 Nov 2018 22:27:53 +0000 Gerrit-HasComments: Yes
