Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 )
Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs ...................................................................... Patch Set 4: (5 comments) Looks good to me. A few nits and one question. http://gerrit.cloudera.org:8080/#/c/11869/4/src/kudu/tablet/compaction_policy-test.cc File src/kudu/tablet/compaction_policy-test.cc: http://gerrit.cloudera.org:8080/#/c/11869/4/src/kudu/tablet/compaction_policy-test.cc@321 PS4, Line 321: if doing so : // doesn't actually reduce the number of rowsets Does it make sense to add a test to see how the compaction algorithm behaves when there are many overlapping smallish rowsets when target size is order of magnitude higher? I might be missing something, but I don't see such a test among the existing ones. http://gerrit.cloudera.org:8080/#/c/11869/4/src/kudu/tablet/compaction_policy-test.cc@336 PS4, Line 336: [0 - 1] nit: it seems this one is extra -- the index starts with 1. Instead, it seem there should be [99-100] trailing one. Maybe, update the lower index range instead. http://gerrit.cloudera.org:8080/#/c/11869/4/src/kudu/tablet/compaction_policy-test.cc@345 PS4, Line 345: ASSERT_EQ(quality, 0.0); nit: the expected values comes first for XXX_EQ() test macros http://gerrit.cloudera.org:8080/#/c/11869/4/src/kudu/tablet/compaction_policy-test.cc@381 PS4, Line 381: if (divisor > 2) { : ASSERT_EQ(rowsets.size(), picked.size()); Should it also hold if the divisor is 3 in case of 3 rowsets? Or it doesn't matter? http://gerrit.cloudera.org:8080/#/c/11869/4/src/kudu/tablet/compaction_policy-test.cc@391 PS4, Line 391: FLAGS_budgeted_compaction_target_rowset_size nit: does it make sense to use 'target_size_bytes' as well? -- To view, visit http://gerrit.cloudera.org:8080/11869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b421c6ed77d28ebab9b91a4d6fcb1e825997e6c Gerrit-Change-Number: 11869 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 14 Nov 2018 19:42:41 +0000 Gerrit-HasComments: Yes
