Hello Andrew Wong, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11943
to review the following change.
Change subject: Fix some issues in HMS and Sentry test fixtures
......................................................................
Fix some issues in HMS and Sentry test fixtures
1. The HMS or Sentry client object may be null in TearDown. If we don't
check, we'll deref a null pointer if there's an error during SetUp()
(e.g. if the HMS or Sentry server failed to start).
2. The HMSCatalogTest fixture should properly chain to its superclass.
Change-Id: Ib0376b972fe6add6d9312aea6944c9ab1a03f25f
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/sentry/sentry-test-base.h
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/11943/1
--
To view, visit http://gerrit.cloudera.org:8080/11943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0376b972fe6add6d9312aea6944c9ab1a03f25f
Gerrit-Change-Number: 11943
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
