Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11798 )
Change subject: [docs] add Hive Metastore integration ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc File docs/hive_metastore.adoc: http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@46 PS2, Line 46: table identifier names Nit: "table name identifiers" to match the other usages in this doc. http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@67 PS2, Line 67: the Hive database and table : name of Kudu tables Should this be rewritten as "the database and table names of Kudu tables"? http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@107 PS2, Line 107: * Add the `kudu-hive.jar` to the HMS classpath. Using HIVE_AUX_JARS_PATH is Is this enough context for an admin to understand what needs to be done? I don't know anything about HMS so HIVE_AUX_JARS_PATH doesn't mean anything to me, but maybe it will to the average person familiar with HMS? http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@107 PS2, Line 107: Using HIVE_AUX_JARS_PATH is : the most common and straightforward This reads like it's missing a noun at the end. Common and straightforward path maybe? http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@122 PS2, Line 122: ## Upgrading Existing Tables I imagine this section may change depending on what the verdict is on external table support. But that can be addressed in a follow-on. http://gerrit.cloudera.org:8080/#/c/11798/2/docs/hive_metastore.adoc@124 PS2, Line 124: When enabling the Hive Metastore integration on a Kudu cluster with existing What happens if you don't run this process? -- To view, visit http://gerrit.cloudera.org:8080/11798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12939c8f2245450ad46898c2050451b090c7ea01 Gerrit-Change-Number: 11798 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 19 Nov 2018 21:55:06 +0000 Gerrit-HasComments: Yes
