Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11958 )
Change subject: [tools] ksck: Add information about replica counts to plain ksck output ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11958/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11958/1//COMMIT_MSG@11 PS1, Line 11: it outputs a 5-number summary of the distribution of : replicas and lists any outliers Maybe your answer to this lies in what you've implemented, but do you think this is useful to include in PLAIN_FULL? http://gerrit.cloudera.org:8080/#/c/11958/1//COMMIT_MSG@26 PS1, Line 26: Small Hrm, I might've missed this. What is this referring to? Also, how are you quantifying what an outlier is? Ah, from the patch it's clear, but mind also noting this in the commit message? Upon googling things, I guess the answer here is obvious... http://gerrit.cloudera.org:8080/#/c/11958/1//COMMIT_MSG@28 PS1, Line 28: In PLAIN_FULL mode it outputs the replica count for every tablet server: : : Tablet Replica Count by Tablet Server : UUID | Host | Replica Count : ----------------------------------+--------------------------------+--------------- : 09d6bf7a02124145b43f43cb7a667b3d | vc1314.halxg.cloudera.com:7050 | 100 : 23d473f441674d43807fd9e631862bfd | vc1308.halxg.cloudera.com:7050 | 100 : 2fb5cdac22b0418bb2df456906e42eb4 | vc1306.halxg.cloudera.com:7050 | 101 : 70f7ee61ead54b1885d819f354eb3405 | vc1316.halxg.cloudera.com:7050 | 95 : 72fcec63e96f4248ae39d114eb3cd7c9 | vc1318.halxg.cloudera.com:7050 | 94 : 86708813b37a44bd8e92c711211c8685 | vc1310.halxg.cloudera.com:7050 | 96 : a662440710624c02bd5612df32cb0235 | vc1302.halxg.cloudera.com:7050 | 101 : c9633273962a4521a32d5e177a118a84 | vc1312.halxg.cloudera.com:7050 | 101 : cc32936bc8594948a04fd4240da36aed | vc1304.halxg.cloudera.com:7050 | 76 : : I also tested it against an empty cluster. Did you test it with the -tables, -tablets configurations? From the implementation, it seems like this should be handled, but it's probably worth a look that it looks ok. -- To view, visit http://gerrit.cloudera.org:8080/11958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e5373033ab84c1e34f9519eb9bd4e04a652c595 Gerrit-Change-Number: 11958 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 20 Nov 2018 02:01:55 +0000 Gerrit-HasComments: Yes
