Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11971 )
Change subject: build: don't instantiate const objects with no user-defined constructor ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc File src/kudu/tools/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc@294 PS1, Line 294: ClusterInfo info > I'm curious whether the following (more idiomatic) would help here: It doesn't; that's actually the first thing I tried :/ http://gerrit.cloudera.org:8080/#/c/11971/1/src/kudu/tools/rebalance_algo-test.cc@324 PS1, Line 324: ClusterInfo info; > ditto Ack -- To view, visit http://gerrit.cloudera.org:8080/11971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21baed51e035d9005453fd7d08274c9c23e74d7 Gerrit-Change-Number: 11971 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Nov 2018 01:03:03 +0000 Gerrit-HasComments: Yes
