Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11859 )
Change subject: (04/05) delta_store: support iteration with is_deleted virtual column ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/11859/3/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/11859/3/src/kudu/common/schema.h@870 PS3, Line 870: size_t should be int because of static const int kColumnNotFound = -1; http://gerrit.cloudera.org:8080/#/c/11859/3/src/kudu/tablet/delta_store.h File src/kudu/tablet/delta_store.h: http://gerrit.cloudera.org:8080/#/c/11859/3/src/kudu/tablet/delta_store.h@356 PS3, Line 356: size_t should be int http://gerrit.cloudera.org:8080/#/c/11859/3/src/kudu/tablet/delta_store.cc File src/kudu/tablet/delta_store.cc: http://gerrit.cloudera.org:8080/#/c/11859/3/src/kudu/tablet/delta_store.cc@249 PS3, Line 249: uint32_t idx_in_block = row_id - prev_prepared_idx_; is this guaranteed to be disjoint from rows in deleted_ ? If so I don't see the point in setting the vcol to false, if not disjoint just wondering why that is. http://gerrit.cloudera.org:8080/#/c/11859/3/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/11859/3/src/kudu/tablet/memrowset.h@598 PS3, Line 598: size_t int here also I think -- To view, visit http://gerrit.cloudera.org:8080/11859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibafcae9f9f82a6c2d9a8afedb8fbf07d6e3069ec Gerrit-Change-Number: 11859 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 21:07:10 +0000 Gerrit-HasComments: Yes
