Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11979 )
Change subject: deflake TsRecoveryITest.TestTabletRecoveryAfterSegmentDelete ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: Code-Review+2 > > > > It does seem kind of unusual that 60s isn't enough to populate three 1MB > > log segments given a write workload of 32KB per row. Did you repro it > > locally by any chance? I wonder what a periodic 'ls -l' of the WAL > > directory would show while the test is running. > > Not quite, but with some extra logging, I could see that slowly, but surely, > the writes (measured in bytes inserted by the TestWorkload) _were_ taking > place over the span of the minute. To clarify, the logging was done running via dist-test; I wasn't able to repro it locally. I ran a flamegraph locally, though, to see if anything stood out as unreasonably slow for the purposes of the test, and compression was the big one. -- To view, visit http://gerrit.cloudera.org:8080/11979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic19d33a5e43aaae21c1cb6273a09a09b1b91f92c Gerrit-Change-Number: 11979 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Thu, 22 Nov 2018 01:44:26 +0000 Gerrit-HasComments: No