Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11982 )
Change subject: [consensus] fix message on unprepared dedup ops ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11982/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11982/3//COMMIT_MSG@9 PS3, Line 9: to fix : the warning message > Hrm, maybe I'm not seeing it. Is this just a cleanup or is it actually fixi Hrm, by my understanding there is a difference: instead of claiming that deduped_req.messages.size() are not prepared, actual number is what's left after the 'iter', i.e. std::distance(iter, messages.end()) - 1. http://gerrit.cloudera.org:8080/#/c/11982/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/11982/3/src/kudu/consensus/raft_consensus.cc@1500 PS3, Line 1500: << "Could not prepare transaction for op " << (*iter)->get()->id() : << " and following " << std::distance(iter, messages.end()) - 1 : << " ops. Status for this op: " << prepare_status.ToString(); > nit: use Substitute? Done -- To view, visit http://gerrit.cloudera.org:8080/11982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9871068743b27720f839797ba6aa6f23cf03a7a Gerrit-Change-Number: 11982 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Mon, 26 Nov 2018 03:06:33 +0000 Gerrit-HasComments: Yes
