Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4491 )
Change subject: KUDU-1563. Add support for INSERT IGNORE ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/4491/17//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/4491/17//COMMIT_MSG@9 PS17, Line 9: Adds `INSERT IGNORE' operation which behaves like a : normal `INSERT' except in the case when a duplicate : row error would be raised by the primary key having been : previously inserted. > I understand MJ's suggestion as making a very extensible framework where a So if I'm understanding you correctly, your suggestion is: - Move forward with a new operation INSERT IGNORE, with the understanding that UPDATE IGNORE and DELETE IGNORE would be good additions in the future. Together they comprise a new set of write operations that may ignore certain errors. - Document that INSERT IGNORE isn't just about duplicate primary keys; the precise set of errors ignored by all of these new write operations is configurable. - Add new KuduSession properties that control the set of errors ignored by write operations. This set will initially just be "duplicate primary key on insert". The properties should be combinable (i.e. I should be able to ignore duplicate primary keys AND missing partitions), but the granularity will be session-level, not operation-level. - Default to...no errors ignored? So that the user is forced to configure the precise set they want to ignore? This makes sense to me, but I suggest building consensus on the approach up front so that you're not forced to reimplement anything if others disagree. -- To view, visit http://gerrit.cloudera.org:8080/4491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c Gerrit-Change-Number: 4491 Gerrit-PatchSet: 17 Gerrit-Owner: Brock Noland <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brock Noland <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 18:49:52 +0000 Gerrit-HasComments: Yes
