Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12043 )
Change subject: build: enable Java flaky test reporting ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/jenkins/build-and-test.sh@244 PS2, Line 244: if [ -n "$KUDU_REPORT_TEST_RESULTS" ] && [ "$KUDU_REPORT_TEST_RESULTS" -ne 0 ]; then Should KUDU_REPORT_TEST_RESULTS be documented at the top of the script? http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/jenkins/build-and-test.sh@259 PS2, Line 259: # Parse out our "build config" - a space-separated list of tags : # which include the cmake build type as well as the list of configured : # sanitizers. Now that this is in build-and-test.sh, we can switch on BUILD_TYPE instead of parsing CMakeCache.txt. http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/report-test.sh File build-support/report-test.sh: http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/report-test.sh@26 PS2, Line 26: # test result server is down. Doc up here what environment variables this script expects to find. Maybe even test that they exist too. http://gerrit.cloudera.org:8080/#/c/12043/2/build-support/report-test.sh@30 PS2, Line 30: ROOT=$(dirname $BASH_SOURCE)/.. Don't need this anymore. -- To view, visit http://gerrit.cloudera.org:8080/12043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifef74fc9bf5453105c267418fa24daf4c33f73f3 Gerrit-Change-Number: 12043 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 06 Dec 2018 18:23:02 +0000 Gerrit-HasComments: Yes
