Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12041 )
Change subject: java: add unit test for RetryRule ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java: http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java@40 PS1, Line 40: public RetryRule () { > Nit: RetryRule() Done http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java@45 PS1, Line 45: protected RetryRule(int retryCount) { > Package private is stricter and sufficient, I think. Done http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java@71 PS1, Line 71: ++attempt; > nit: I think attempt++ makes the most sense here given there is no need to Done http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java File java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java: PS1: > License header. Done http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java@10 PS1, Line 10: private int failures = 0; > nit: put this inside the test method. can't do that ... this controls when the test stops failing. I'll add a comment. http://gerrit.cloudera.org:8080/#/c/12041/1/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestRetryRule.java@21 PS1, Line 21: assertFalse("" + failures + " failures", true); > Maybe use String.format()? "" + ... is a little weird. Done -- To view, visit http://gerrit.cloudera.org:8080/12041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4bb578b550c3ccb3ce5526a4ca87abafd7d4021 Gerrit-Change-Number: 12041 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 18:52:32 +0000 Gerrit-HasComments: Yes
