Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12060 )

Change subject: KUDU-1375: [docs] Remove "binaries" in the Build from Source 
section
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc@420
PS2, Line 420: NOTE: 'make install' does not copy Kudu binaries. You need to 
manually copy them
> This text block should be replicated into the other _from_source sections (
Done


http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc@424
PS2, Line 424: the your
> Nit: drop one of these.
Done


http://gerrit.cloudera.org:8080/#/c/12060/2/docs/installation.adoc@426
PS2, Line 426: if you use the default installation directory
> I would tie this more directly to DESTDIR from L413-414.
Done



--
To view, visit http://gerrit.cloudera.org:8080/12060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b1e7337cdd9f04eea1c2b4da3d27b9815553121
Gerrit-Change-Number: 12060
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Dec 2018 00:46:29 +0000
Gerrit-HasComments: Yes

Reply via email to