Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 )
Change subject: KUDU-2636: LBM supports deleting dead and full containers ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12075/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/12075/1/src/kudu/fs/log_block_manager.cc@1179 PS1, Line 1179: : /////////////////////////////////////////////////////////// : // LogBlockCreationTransaction : //////////////// > I did miss the question :( It's certainly possible to automatically delete one of a given file pair (xxx.data and xxx.metadata) if the other of the pair is missing. I'm not sure that this wise, though, given that we don't know at startup _why_ the files are missing. If a rogue admin accidentally deleted all of the .metadata files, do you want Kudu to delete the .data files as a result? Seems like failing to start and forcing the admin to investigate is the safer option. -- To view, visit http://gerrit.cloudera.org:8080/12075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d3672ae3c3dd9acd489120d653c44a641537f10 Gerrit-Change-Number: 12075 Gerrit-PatchSet: 2 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Fri, 14 Dec 2018 01:09:59 +0000 Gerrit-HasComments: Yes
