Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12093 )
Change subject: [client] clang: explicit override in C++11 mode only ...................................................................... [client] clang: explicit override in C++11 mode only While playing with the Kudu C++ example application, I noticed that clang emits a lot of compilation warnings about using the explicit override for virtual methods. This patch addresses that, updating the OVERRIDE macro to take into account the version of the C++ standard the compiler is using while compiling a Kudu client application. Change-Id: I2e11c6ce830e0b525a1b92af126f10de745c986a Reviewed-on: http://gerrit.cloudera.org:8080/12093 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/client/stubs.h 1 file changed, 14 insertions(+), 11 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2e11c6ce830e0b525a1b92af126f10de745c986a Gerrit-Change-Number: 12093 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
