Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12038 )
Change subject: [tools] ksck output could be filtered by sections ...................................................................... Patch Set 6: (10 comments) Looks good. Just a few small things. http://gerrit.cloudera.org:8080/#/c/12038/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12038/6//COMMIT_MSG@7 PS6, Line 7: ksck output could be filtered by sections Allow ksck output to be filtered by section http://gerrit.cloudera.org:8080/#/c/12038/6//COMMIT_MSG@10 PS6, Line 10: which is and http://gerrit.cloudera.org:8080/#/c/12038/6//COMMIT_MSG@10 PS6, Line 10: could may http://gerrit.cloudera.org:8080/#/c/12038/6//COMMIT_MSG@11 PS6, Line 11: `--sections` http://gerrit.cloudera.org:8080/#/c/12038/6//COMMIT_MSG@11 PS6, Line 11: filte filter http://gerrit.cloudera.org:8080/#/c/12038/6//COMMIT_MSG@10 PS6, Line 10: , : this . This http://gerrit.cloudera.org:8080/#/c/12038/6//COMMIT_MSG@11 PS6, Line 11: add adds http://gerrit.cloudera.org:8080/#/c/12038/6/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/12038/6/src/kudu/tools/ksck-test.cc@827 PS6, Line 827: results.master_summaries : vector<KsckServerHealthSummary>() I think it would be clearer if you wrapped the third parameter to CheckJsonVs* functions in boost::optional and then passed either the value from `results` or boost::none into these functions. http://gerrit.cloudera.org:8080/#/c/12038/6/src/kudu/tools/ksck-test.cc@836 PS6, Line 836: CheckJsonVsVersionSummaries Thanks for adding this. http://gerrit.cloudera.org:8080/#/c/12038/6/src/kudu/tools/ksck-test.cc@852 PS6, Line 852: CheckJsonVsCountSummaries And this! -- To view, visit http://gerrit.cloudera.org:8080/12038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic31dcb7795b5c510b40fa2024960306b9da40e05 Gerrit-Change-Number: 12038 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 26 Dec 2018 15:59:44 +0000 Gerrit-HasComments: Yes
