Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12087 )
Change subject: KUDU-2640: Add Spark Structured Streaming Sink ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12087/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12087/2//COMMIT_MSG@9 PS2, Line 9: patche typo http://gerrit.cloudera.org:8080/#/c/12087/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: http://gerrit.cloudera.org:8080/#/c/12087/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@466 PS2, Line 466: batchId: Long > May be obvious, but mind adding a small note on why we shouldn't use this? Yeah, a comment would be nice. I'm assuming this is for de-duplication in the case of spark streaming retrying a batch operation. http://gerrit.cloudera.org:8080/#/c/12087/2/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/StreamingTest.scala File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/StreamingTest.scala: http://gerrit.cloudera.org:8080/#/c/12087/2/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/StreamingTest.scala@38 PS2, Line 38: def testKuduContextWithSparkStreaming() { seems to be missing a structured streaming test using a streaming SQL query -- To view, visit http://gerrit.cloudera.org:8080/12087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I731e35f82c8cca7d911e4d879aa6853112132b17 Gerrit-Change-Number: 12087 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 02 Jan 2019 19:54:11 +0000 Gerrit-HasComments: Yes
