Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 )
Change subject: docs: update guidance for binding functions ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc File docs/contributing.adoc: http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc@312 PS1, Line 312: Callback goes out of scope nit: the counterpart about std::function has the name of the class with grave accents, maybe add them here as well. -- To view, visit http://gerrit.cloudera.org:8080/12146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I326931a096b7184d403aea116248cffcde5c9775 Gerrit-Change-Number: 12146 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 03 Jan 2019 00:32:51 +0000 Gerrit-HasComments: Yes
