Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12147 )
Change subject: java: KuduBinaryExtractor should use the thread context classloader ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12147/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java: http://gerrit.cloudera.org:8080/#/c/12147/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@54 PS1, Line 54: /** Return the thread context classloader or the parent classloader for this class. */ > Do we have any documentation on this? I don't want to violate any style gui While I can't find the documentation on this, we used to use the Google style guide for Java which explicitly allows this: https://google.github.io/styleguide/javaguide.html#s7.1.1-javadoc-multi-line I think if we are still using the Google Java style guide then we should add a link to it on https://github.com/cloudera/kudu/blob/master/docs/contributing.adoc#java-code-style or if not then we should specify which Java style guide we are following to avoid disagreements based on a difference of personal preference. -- To view, visit http://gerrit.cloudera.org:8080/12147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e1cf188bb557eeaea0b2867243855f3f2d121f1 Gerrit-Change-Number: 12147 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Brian McDevitt <br...@phdata.io> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Thu, 03 Jan 2019 17:30:26 +0000 Gerrit-HasComments: Yes
