Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12148 )
Change subject: python: fix tests run in Python 3.4 environments ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12148/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/12148/1/build-support/jenkins/build-and-test.sh@461 PS1, Line 461: CC=$CLANG CXX=$CLANG++ > If everything that requires compilation needs to run with the current value Maybe, but I like that this way we see which steps explicitly require compilation and which don't (though there's less and less of that now). All of this is due for a rewrite; the lack of code sharing between the two Python steps is frustrating. I just didn't have the heart and decided to just apply yet another bandaid. -- To view, visit http://gerrit.cloudera.org:8080/12148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8683c6d24b3b808384a7e4d63142a78f3a7ee5f0 Gerrit-Change-Number: 12148 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 03 Jan 2019 21:27:30 +0000 Gerrit-HasComments: Yes
