Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11377 )
Change subject: KUDU-2411. Add scripts to build binaries for testing use ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11377/3/build-support/relocate_binaries_for_mini_cluster.py File build-support/relocate_binaries_for_mini_cluster.py: http://gerrit.cloudera.org:8080/#/c/11377/3/build-support/relocate_binaries_for_mini_cluster.py@217 PS3, Line 217: : def copy_file(src, dest): : > To me it wasn't so much about performance but about more user-friendly flow Thanks for clarifying your thought process. Your point about erroring out before making any changes on disk is fair, but since in this case that would only entail creating a few output directories it's not very serious. Since you don't feel strongly about it then let's leave it as-is for now, because I'm not motivated enough by the tradeoffs (slight user friendliness improvement vs slight maintainability edge) to feel like it's worth another revision of this patch. -- To view, visit http://gerrit.cloudera.org:8080/11377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f90cfe80f6830177bf6ea9e0711eb0d034f75 Gerrit-Change-Number: 11377 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 04 Jan 2019 23:14:05 +0000 Gerrit-HasComments: Yes
