Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12166 )
Change subject: KUDU-2652: deflake TsRecoveryITest.TestNoBlockIDReuseIfMissingBlocks ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12166/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12166/1//COMMIT_MSG@11 PS1, Line 11: This patch makes orphaned block : generation faster by making the workload update a single row. > I would also suspect Will's compaction changes; I wonder if flushing outstr >Hmm, why is this obviously faster? The default is a random write workload, no a sequential one. It's a bit harder to reason about what the rowsets look like, but I'd expect either sequential writes or single-row-updates to definitely generate orphaned blocks. >I also wonder why this surfaced just now. I actually just saw this fail in a Cloudera-internal 1.8 build, so I don't think the flakiness was introduced by the recent compaction policy changes. http://gerrit.cloudera.org:8080/#/c/12166/1/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: http://gerrit.cloudera.org:8080/#/c/12166/1/src/kudu/integration-tests/ts_recovery-itest.cc@257 PS1, Line 257: // We want to generate orphaned blocks, so use a workload that we expect to > I think the explanation is that we end up generating lots of (major and/or Done, yes. -- To view, visit http://gerrit.cloudera.org:8080/12166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24a689702d29a744be8c113fedafec0307a90b1c Gerrit-Change-Number: 12166 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 08 Jan 2019 23:48:40 +0000 Gerrit-HasComments: Yes
