Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12183 )
Change subject: [gutil] suppress -Wdeprecated-declarations warning on macOS ...................................................................... [gutil] suppress -Wdeprecated-declarations warning on macOS As it turned out, most of the atomic functions used in atomicops-internals-macosx.h have been declared deprecated since macOS 10.12, most of the functions in the SASL API are deprecated since macOS 10.11, and the krb5 API is deprecated in favor of GSS.framework. To avoid multiple compilation warnings on macOS while compiling with clang from the Xcode development environment, this changelist adds 'pragma GCC diagnostic push/pop' for the '-Wdeprecated-declarations' flag accordingly. It's confirmed that this patch suppresses deprecation warnings at least on macOS 10.14. This is a follow-up to 678dbac6fb05d0370e40e6645d4b1ec530fa0180. Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860 Reviewed-on: http://gerrit.cloudera.org:8080/12183 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/gutil/atomicops-internals-macosx.h M src/kudu/rpc/client_negotiation.cc M src/kudu/rpc/negotiation-test.cc M src/kudu/rpc/sasl_common.cc M src/kudu/rpc/sasl_common.h M src/kudu/rpc/server_negotiation.cc M src/kudu/security/init.cc M src/kudu/thrift/sasl_client_transport.cc 8 files changed, 85 insertions(+), 0 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I82b0ebd9917a567d1a8b72c80b47dc102304d860 Gerrit-Change-Number: 12183 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]>
