Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12208 )
Change subject: [examples] a small update on SparkExample ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12208/3/examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala File examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala: http://gerrit.cloudera.org:8080/#/c/12208/3/examples/scala/spark-example/src/main/scala/org/apache/kudu/spark/examples/SparkExample.scala@130 PS3, Line 130: // Catch, log and re-throw. Not the best practice, but this is a very : // simplistic example. : case unknown : Throwable => logger.error(s"got an exception: " + unknown) : throw unknown > nit: Will this display the exception twice? If so, maybe just throw? Or jus Yep, I guess so. Anyway, I think I'll address this separately once I get a chance -- it seems I'll be touching this small example once more soon. -- To view, visit http://gerrit.cloudera.org:8080/12208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf8c4e675ca6c240582242658fa8173a1ccd271d Gerrit-Change-Number: 12208 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Sat, 19 Jan 2019 00:28:04 +0000 Gerrit-HasComments: Yes
