Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] throw exception if applying operation on a closed session ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12237/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12237/4//COMMIT_MSG@14 PS4, Line 14: This is a breaking change for clients that relied on the old broken : behavior; they will now throw. Thus I'm not sure we actually want this. Could throwing an exception in the specified case be optional? I guess by default we want to throw, but if some property specified for Kudu client, then there will be just a warning message logged? -- To view, visit http://gerrit.cloudera.org:8080/12237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9 Gerrit-Change-Number: 12237 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 19 Jan 2019 01:00:04 +0000 Gerrit-HasComments: Yes
