helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12254 )
Change subject: KUDU-2665: deflake block_manager-stress-test ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12254/1/src/kudu/fs/block_manager-stress-test.cc File src/kudu/fs/block_manager-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/12254/1/src/kudu/fs/block_manager-stress-test.cc@550 PS1, Line 550: // Quiesce the block manager before injecting inconsistencies so that the two : // don't interfere with one another. : this->bm_.reset(); > I have just read through the code of 'block_manager-stress-test'. I agree w BTW, i prefer 2), and let 'dd_manager_' continue to run. -- To view, visit http://gerrit.cloudera.org:8080/12254 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0be328f740056cd6b64c9881759225c8b961a935 Gerrit-Change-Number: 12254 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Wed, 23 Jan 2019 03:20:32 +0000 Gerrit-HasComments: Yes
