Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12255 )
Change subject: python: fix Python 3.4 based tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12255/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12255/1//COMMIT_MSG@9 PS1, Line 9: Pip released 19.0 recently and tests based on Python 3.4 started to fail : with ImportError Would be good to include the error message in fail, to help searching in the future. http://gerrit.cloudera.org:8080/#/c/12255/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/12255/1/build-support/jenkins/build-and-test.sh@518 PS1, Line 518: # Even though Python 3.4 is no longer supported starting from pip 19.1, attempting : # to upgrade to pip 19.0 on Python 3.4 with pandas 0.22 yields errors. Therefore, : # pin to the last pip version that works. I filed an upstream bug with pip: https://github.com/pypa/pip/issues/6175. Could you reword to link to that bug report, so that we'll have more information? Something like: # new version of pip to proceed. # # pip 19.1 doesn't support Python 3.4, which is the version of Python 3 # shipped with Ubuntu 14.04. However, there appears to be a bug[1] in pip 19.0 # preventing it from working properly with Python 3.4 as well. Therefore we # must pin to a pip version from before 19.0. # # 1. https://github.com/pypa/pip/issues/6175 -- To view, visit http://gerrit.cloudera.org:8080/12255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecbc55877e832a0ef437d2799e09c39fb314cb95 Gerrit-Change-Number: 12255 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Jan 2019 06:53:41 +0000 Gerrit-HasComments: Yes
