helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12239 )
Change subject: [fs]: delete the (orphaned) metadata file when repairing ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12239/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12239/4//COMMIT_MSG@9 PS4, Line 9: This patch intends to delete the (orphaned) metadata file at : startup while the data file has gone missing and the metadata : file has no live blocks at the same time. In the previous patch : KUDU-2636, it has supported deleting the dead container which : includes data file and metadata file. So, there will be a time : window while deleting both of these two files in sequential, : and it will make a half-container in extreme cases, especially : in a crash or sent the tserver a kill -9. Indeed, Adar has : captured this type of case under 1000 runs of dense_node-itest. > Thanks for the added detail. Could you reword this a bit to add more clarit Done -- To view, visit http://gerrit.cloudera.org:8080/12239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a4223d0e6385a7f7776f8fe2679a3bb16d832ab Gerrit-Change-Number: 12239 Gerrit-PatchSet: 4 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Wed, 23 Jan 2019 11:29:21 +0000 Gerrit-HasComments: Yes
