Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12173 )
Change subject: [docker] Add an initial docker build ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12173/3/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/12173/3/docker/Dockerfile@57 PS3, Line 57: # : # ---- Thirdparty ---- : # Builds an image that has Kudu's thirdparty dependencies built. : # This is done in it's own stage so that docker can cache it and only : # run it when thirdparty has changes. : # While not necessary, maybe we should consider installing ccache/ninja (though maybe as a follow-on patch if it turns out being a headache). This could be super useful as a developer tool wanting to develop/test on different environments, so it might be helpful to include iterative dev tools out of the box. http://gerrit.cloudera.org:8080/#/c/12173/3/docker/bootstrap-env.sh File docker/bootstrap-env.sh: http://gerrit.cloudera.org:8080/#/c/12173/3/docker/bootstrap-env.sh@28 PS3, Line 28: # Install the prerequisite libraries, if they are not installed. I know it's not in the upstream installation docs, but it's probably worth adding nscd, or a TODO to add it in case people use this and run into issues: https://www.cloudera.com/documentation/enterprise/latest/topics/kudu_troubleshooting.html#slow_dns_nscd -- To view, visit http://gerrit.cloudera.org:8080/12173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95497b39e47f07301be75cbadd814656c7e2ea42 Gerrit-Change-Number: 12173 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Jan 2019 19:51:48 +0000 Gerrit-HasComments: Yes
