Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12252 )
Change subject: [spark] Add some logging to trace KuduContext operations ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12252/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/12252/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@246 PS1, Line 246: log.info > Maybe, move this into writeRows() itself? It seems there are enough parame There's two reasons I made it this way: 1. Nicer logs. Insert/upsert/update/delete conjugate differently and use different prepositions, e.g. "inserted" (add -ed) vs. "deleted" (add -d), and "insert into" vs. "delete from". 2. This doesn't feel worse to me than two big `match` statements in `writeRows` to do the logging cleanly. If it bugs you that much, feel free to make a follow-up that changes it :) -- To view, visit http://gerrit.cloudera.org:8080/12252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6741f2584c1bc6b229d10d37297515474318f94c Gerrit-Change-Number: 12252 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 23 Jan 2019 19:57:52 +0000 Gerrit-HasComments: Yes
