Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12274 )
Change subject: Fix master_sentry-itest built in RELEASE mode ...................................................................... Patch Set 1: (1 comment) > It is necessary to not break macOS build. So the macOS build is already broken? Or is it somehow broken from this change? If the latter, I don't understand why; we've been building sentry_authz_provider.cc on macOS for some time. http://gerrit.cloudera.org:8080/#/c/12274/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/12274/1/src/kudu/master/catalog_manager.cc@747 PS1, Line 747: authz_provider_.reset(new master::SentryAuthzProvider()); > Right, the constructor of SentryAuthzProvider isn't doing anything. I thought when the full Sentry integration is merged, Start/Stop will be called unconditionally, and the gflag will control whether we construct a SentryAuthzProvider or a DefaultAuthzProvider? Since you're doing everything but Start/Stop in this patch, why not use that gflag control now too? -- To view, visit http://gerrit.cloudera.org:8080/12274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e90b2dc5372c87b78d381f04780f6b5db60271c Gerrit-Change-Number: 12274 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 25 Jan 2019 05:35:15 +0000 Gerrit-HasComments: Yes
