Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 )
Change subject: binary artifact: generate properties file ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh File build-support/build_mini_cluster_binaries.sh: http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh@38 PS1, Line 38: # META-INF/apache-kudu-test-binary.properties This should be updated to reflect the infixes that vary (i.e. arch, platform, etc.) http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh@137 PS1, Line 137: PROP_FILE="$PROP_DIR/apache-kudu-test-binary.properties" Would it be possible to extract the filename, OS, and arch from ARTIFACT_NAME (i.e. the output of the python script)? -- To view, visit http://gerrit.cloudera.org:8080/12314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4 Gerrit-Change-Number: 12314 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 Jan 2019 20:59:57 +0000 Gerrit-HasComments: Yes
