Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12319 )
Change subject: KUDU-2411: Altered binary jar extractor API ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12319/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java: http://gerrit.cloudera.org:8080/#/c/12319/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@140 PS2, Line 140: if (Files.notExists(target)) { can we add something like this: checkArgument("jar".equals(src.getScheme()), "src URI must use a jar: scheme"); Or if not validation then at least a Javadoc comment about how we expect a jar: URI scheme? http://gerrit.cloudera.org:8080/#/c/12319/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@145 PS2, Line 145: env.put("create", "true"); Why do we want to create a new zip file if one does not exist? Per https://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/zipfilesystemproviderprops.html -- To view, visit http://gerrit.cloudera.org:8080/12319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebd9d8f2341b1a2a109dda93b167bcb47b1fe49a Gerrit-Change-Number: 12319 Gerrit-PatchSet: 2 Gerrit-Owner: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 30 Jan 2019 22:47:43 +0000 Gerrit-HasComments: Yes
