Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12261 )
Change subject: [spark] Add write duration histograms ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12261/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12261/1//COMMIT_MSG@14 PS1, Line 14: 25.0%: 14ms, 25.0%: 14ms > Why does it have information on every bin duplicated in the output? Is it Because there are so few values. It's because of the HdrHistogram's implementation and I don't think it's worth doing anything about because it's an edge case and the numbers are still correct. http://gerrit.cloudera.org:8080/#/c/12261/1//COMMIT_MSG@21 PS1, Line 21: need to be shipped between executors and the driver, so : their (serialized) size is relevant > How often does that happen? Does it depend on the granularity of the histo When tasks end and on executor heartbeat. Executor heartbeat is every 10s (from https://spark.apache.org/docs/latest/configuration.html). So it's not so often. -- To view, visit http://gerrit.cloudera.org:8080/12261 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fd4d380b08bd7d7d5c1e65b79cffb44a9b9d433 Gerrit-Change-Number: 12261 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 31 Jan 2019 18:30:07 +0000 Gerrit-HasComments: Yes
