Will Berkeley has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12326


Change subject: Add tracing to StartTabletCopy
......................................................................

Add tracing to StartTabletCopy

This patch adds tracing information to the StartTabletCopy RPC. The
sequence of events is the following:

1. A remote peer initiates a tablet copy on the local peer via
   StartTabletCopy.
2. The local peer starts processing the StartTabletCopy. If the copy is
   copying over an existing, running replica, the replica is shutdown and
   tombstoned (so its data is deleted).
3. The local peer creates a tablet copy client.
4. The local peer opens a tablet copy session between the local and
   remote peer by calling BeginTabletCopySession on the remote peer. The
   local peer downloads the tablet superblock as part of this.
5. The local peer either
     a. replaces tombstoned metadata with new metadata, or
     b. writes new tablet metadata.
6. The local peer writes the new consensus metadata for the tablet.
7. The local peer responds to the StartTabletCopy. Downloading data and
   WALs occurs asynchronously, managed by the tablet copy session.

Steps 2 and 4-6 may be slow due to disk or network I/O, but there was no
tracing to help diagnose the source of slowness in cases where
StartTabletCopy was slow. This patch adds simple tracing for the
completion of steps 2, 4, 5a, 5b, and 6, plus a trace message for when
the replica is registered with the tablet manager at the end of the
processing of the RPC.

Change-Id: I3f32871f3ac1c0d4513a9ba2c955be42dd6e478e
---
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/tserver/ts_tablet_manager.cc
2 files changed, 13 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/12326/1
--
To view, visit http://gerrit.cloudera.org:8080/12326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f32871f3ac1c0d4513a9ba2c955be42dd6e478e
Gerrit-Change-Number: 12326
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <[email protected]>

Reply via email to