Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12316 )
Change subject: KUDU-2477: highlight primary key in master Web UI ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12316/3/www/table.mustache File www/table.mustache: http://gerrit.cloudera.org:8080/#/c/12316/3/www/table.mustache@52 PS3, Line 52: {{name}} {{#is_key}}<img src="key.png" width=12 height=6 />{{/is_key}} > yep, I think this looks better with image before column name. I am also on Hmm, the colors make the white inside the keyhole stand out. I'd also vote for no colors and prefix. -- To view, visit http://gerrit.cloudera.org:8080/12316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cb876ca0b66a78e82714f503c0e52f21706a8fc Gerrit-Change-Number: 12316 Gerrit-PatchSet: 3 Gerrit-Owner: Greg Solovyev <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 31 Jan 2019 19:40:01 +0000 Gerrit-HasComments: Yes
