Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12322 )
Change subject: [java] better client and minicluster cleanup after tests finish ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/12322/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12322/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@1060 PS1, Line 1060: AsyncKuduClient asyncKuduClient = new AsyncKuduClient : .AsyncKuduClientBuilder(harness.getMasterAddressesAsString()) : .defaultAdminOperationTimeoutMs(harness.DEFAULT_SLEEP) : .build(); BTW, why not to put this AsyncKuduClient instance into the auto-close closure? I would expect that way the access to the async- and the derived sync-client would be automatically restricted to a closure where they are valid. Why putting just the derived KuduClient is better? -- To view, visit http://gerrit.cloudera.org:8080/12322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If91b3b2787915f0361537dd999e0daa8f7cb0a36 Gerrit-Change-Number: 12322 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 31 Jan 2019 20:03:55 +0000 Gerrit-HasComments: Yes
